Create 'Card + Circle Image' Block Type

unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln

https://cms.unl.edu

GNU General Public License v2.0

5 stars 6 forks source link

Create 'Card + Circle Image' Block Type #111

Closed macburgee1 closed 4 years ago

macburgee1 commented 4 years ago

(We need a better name for this block type.)

Headline
- Text
- Required
Headline Link
- Link
- URL only; no link text
- Optional
- Headline is rendered as link if Headline Link is populated
Body
- Rich text
- Required
- Add new text format (Body Block Centered); based on Body Block with lists removed as those won't work well with centered text
Image
- Image
- ~~Optional~~ Required
- Ratio: 1:1
- Offer image border option?
CTA
- Link
- Both URL and link text are required
- Optional

macburgee1 commented 4 years ago

macburgee1 commented 4 years ago

Blocked by #90

macburgee1 commented 4 years ago

Unblocked

macburgee1 commented 4 years ago

Per group consensus, the name is 'Card + Circle Image'. The image field is now required.

macburgee1 commented 4 years ago

Note: inverse behavior is also accounted before.

ericras commented 4 years ago

I am not seeing dcf-inverse cascade down:

ericras commented 4 years ago

It's because $variables['element']['#object']->__get('#section_classes'); is not looking at section class packages.

EDIT: I'm working on it

ericras commented 4 years ago

Oh jeez 2eb69b3 is what is in #125 - sorry

macburgee1 commented 4 years ago

When I was working on #125, I should have thought about this PR. I just pushed a commit that updates the Headline field template to mirror that of the Card block type. That fixes an issue where dcf-inverse only gets applied to the headline if it's a link.