unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln

https://cms.unl.edu

GNU General Public License v2.0

5 stars 6 forks source link

News item follow up #139

Closed ericras closed 4 years ago

ericras commented 4 years ago

Follow up to items in https://github.com/unlcms/project-herbie/pull/92#issuecomment-536689396

92

Also: add permissions

macburgee1 commented 4 years ago

I created a branch: issue-139-news-followup

The last commit adds a "Recent News" custom block to replace the default block provided by views.

macburgee1 commented 4 years ago

All issues have been addressed.

ericras commented 4 years ago

AJAX calls fail in the Views edit interface.

Location: /web/admin/structure/views/ajax/display/news_recent/block_1/block_hide_empty?_wrapper_format=drupal_ajax

Notice: Undefined index: use_more_text in unl_views_form_views_ui_edit_display_form_alter() (line 33 of /Library/WebServer/Documents/workspace/project-herbie/web/modules/custom/unl_views/unl_views.module)

Error: Call to a member function __toString() on null in unl_views_form_views_ui_edit_display_form_alter() (line 33 of /Library/WebServer/Documents/workspace/project-herbie/web/modules/custom/unl_views/unl_views.module)

Fixed with 459b762

macburgee1 commented 4 years ago

Let's discuss the category label at Monday's weekly meeting

macburgee1 commented 4 years ago

Per discussion at this week's meeting, we're replacing the "UNL" category. Any custom blocks are probably UNL-related anyway. For now, we're going with a type-of-block convention as opposed to a type-of-content convention. Type of block means views, menus, users. Type of content means news, events, people, etc. In this case, we're using "Aggregated Content" in lieu of "Views" because "Views" is a Drupalism without meaning to end users.