search

unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln
https://cms.unl.edu
GNU General Public License v2.0
5 stars 6 forks source link

Update unl_multisite module #198

Closed ericras closed 4 years ago

macburgee1 commented 4 years ago

Quick question - why change the location for drush packages to 'drush/Commands/contrib'?

ericras commented 4 years ago

Because there was an existing file in /drush/Commands (https://github.com/unlcms/project-herbie/blob/master/drush/Commands/PolicyCommands.php) so then any additional things put in that folder would need individual entries in .gitignore.

That file (https://github.com/unlcms/project-herbie/blob/master/drush/Commands/PolicyCommands.php) is from the original use of drupal-composer/drupal-project. Should we just remove that and undo my commit?

macburgee1 commented 4 years ago

That's a good catch. I missed that when I replaced the Composer scaffolding. Let's remove PolicyCommands.php and then we don't need to namespace with 'contrib'.

ericras commented 4 years ago

Updated and ready for review