search

unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln
https://cms.unl.edu
GNU General Public License v2.0
5 stars 6 forks source link

Install ImageMagick module #22

Closed macburgee1 closed 1 year ago

macburgee1 commented 5 years ago

https://www.drupal.org/project/imagemagick

version 8.x-2.4 instead of 8.x-1.0-alpha

macburgee1 commented 5 years ago

Referenced config from unlcms/UNL-CMS-2. I left 'path_to_binaries' empty, and it runs fine in Lando. Unless there's a reason on production to set the path, I think we're good here. @ericras thoughts?

ericras commented 5 years ago

Should be ok without the path. Running convert works on the production server.

ericras commented 5 years ago

On my machine without the path I get "sh: convert: command not found" even though convert exists

ericras commented 5 years ago

Looks like to run this on a mac you need the path set

https://stat.ethz.ch/pipermail/r-sig-mac/2014-October/011144.html

It is, because Yosemite ignores PATH for processes started from a GUI application. You will see if you run
system("echo $PATH")

You have to use full paths in Yosemite for anything that is not on the "sanctioned" PATH -- or use R from the shell.
macburgee1 commented 5 years ago

That's a good catch. Because the path may differ from dev machine to dev machine, we'll probably want to use $config['imagemagick.settings']['path_to_binaries'] = "path/to/binaries"; locally in settings.php.

macburgee1 commented 5 years ago

@ericras - Does the solution above work? Can we close this issue?

ericras commented 5 years ago

We probably need development/local settings set up and this referenced in the README

macburgee1 commented 5 years ago

That sounds like a good idea. Anything that is global for the development environment should probably go in web/profiles/herbie/includes/settings.php.inc. Configuration that may differ from development environment to development environment would be suitable for settings.local.php. The path to ImageMagick binaries would seem to fit in the latter category.