search

unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln
https://cms.unl.edu
GNU General Public License v2.0
5 stars 6 forks source link

svg_support#369 code #381

Closed sarongebre closed 1 year ago

sarongebre commented 1 year ago

Closes #369

ericras commented 1 year ago

It looks like the mere presence of the focal_point module causes an error when inserting an svg.

TypeError: Drupal\focal_point\FocalPointManager::saveCropEntity(): Argument #3 ($width) must be of type int, null given, called in web/modules/contrib/focal_point/focal_point.module on line 99 in Drupal\focal_point\FocalPointManager->saveCropEntity() (line 94 of web/modules/contrib/focal_point/src/FocalPointManager.php).
ericras commented 1 year ago

We were planning on removing focal_point anyway. I'll plan on merging this then do that as a follow up #384

ericras commented 1 year ago
  1. svg_image and svg_image_responsive need enabled on all sites

php drush-all-sites.php pm:enable svg_image_responsive svg_image

  1. imagemagick settings need updated on all sites.

Added php drush-all-sites.php config:delete imagemagick.settings image_formats.SVG.enabled to milestne 10.2