search

unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln
https://cms.unl.edu
GNU General Public License v2.0
5 stars 6 forks source link

Allow Tables in CKEditor #49

Closed macburgee1 closed 5 years ago

macburgee1 commented 5 years ago

Content creators will have valid uses for tables. Let's discuss how to best support tables in CKEditor.

macburgee1 commented 5 years ago

Per Ryan, we'll need to automatically class all tables with '.dcf-table'. We have a couple of options:

  1. Write a CKEditor plugin
  2. Write an input filter

We'll also be adding the ability to add a responsive table class with CKEditor's Style menu. Either method above will need to respect existing classes, such as the responsive table class.

macburgee1 commented 5 years ago

I went the CKEditor plugin route because we'll want the classes applied within CKEditor when the user will be editing . It's in a 'CKEditor DCF' module, which can include additional plugins that we may need.

Two questions:

  1. Is this Drupal module its own project?
  2. Should the plugin be abstracted as its own project (i.e. just a CKEditor plugin without any Drupal code)?
macburgee1 commented 5 years ago

Talked to Eric. No abstraction. This module will live in web/modules/custom.

macburgee1 commented 5 years ago

The the horses. I'm going to rename the module dcf_ckeditor

macburgee1 commented 5 years ago

Review can proceed