Closed ericras closed 5 years ago
Base on "USING an alternate 'class'" where we'll want layout settings like css classes and background image, i think we probably want to create a "DCF Layouts" module
Will probably want to split the DCF layouts module out into its own project someday but for now i've just included it in the main project
dcf_layouts.info.yml
dependencies:
- - layout_builder
+ - layout_discovery
If DCF Layouts is going to reside within this project (for now), it should be moved to /web/modules/custom/dcf_layouts
Code Review
$ phpcs --standard=Drupal,DrupalPractice dcf_layouts/
Time: 98ms; Memory: 8MB
Issue 1 in dcf_layouts.info.yml can be ignored. This module isn't being hosted on Drupal.org.
4. Layout implementation issues - There are issues with some of the layouts. I'll document those in a separate post.
5. We should have a conversation about the Builder Page content type and how it fits within a larger content strategy.
DCF One Column
DCF Two Column
DCF Three Column
DCF Four Column
Add config and theme them.This is a meta issue as this may be better broken up (into a carousel issue, grid layouts issue, and on and on)