unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln
https://cms.unl.edu
GNU General Public License v2.0
5 stars 6 forks source link

Tandem basic option #668 #675

Open sarongebre opened 1 month ago

sarongebre commented 1 month ago

Closes #668

Below are screenshots of the labels. It can be changed if you have other suggestions. Thanks.

Also, the hide-and-show processes should work fine now. Tried a different approach after our discussion. I am using the "invisible" property now instead of the "visible" one when using the #states process. I also set the default value of the "Add Image Shadow" field to "Yes". These two changes seem to have resolved the issue...

However, using the "visible" property and the "AND" condition in the #states in Drupal still has issues when the form changes or when a user uploads an image. (Not using this approach anymore so we should be good)

image

image

Label Shadow Position image

There are some code changes that were made in #662 that may need to be pushed to live first before this pull request. I believe I incorporated a lot of those changes already in this pull request but there are some changes like the "Buttons" in the Herbie theme file that I haven't added.