search

unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln
https://cms.unl.edu
GNU General Public License v2.0
6 stars 7 forks source link

Hero image `source` is missing `em` unit in the media query #771

Closed skoolbus39 closed 2 months ago

skoolbus39 commented 3 months ago

The media attribute for the hero image source has a value that is missing the em unit. Here is the current code:

<source srcset="/sites/unl.edu.business-and-finance.sustainability/files/styles/16_9_2129x1198/public/media/image/about-hero.png?itok=0h4GbjyY 1x, /sites/unl.edu.business-and-finance.sustainability/files/styles/16_9_3192x1796/public/media/image/about-hero.png?itok=zxnDFAZu 1.5x, /sites/unl.edu.business-and-finance.sustainability/files/styles/16_9_4258x2395/public/media/image/about-hero.png?itok=_kxkl7Sm 2x" media="all and (min-width: 99.78)" type="image/png"/>

Instead, it should be media="all and (min-width: 99.78em)".

Here is an example of the error on WebAudit.

sarongebre commented 2 months ago

This issue was addressed in issue #689. The site wasn't reflecting the changes due to caching issues. I cleared the cache, which resolved the syncing problem.