unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln
https://cms.unl.edu
GNU General Public License v2.0
5 stars 6 forks source link

Create Details/Summary (Accordion) Block Type #91

Closed macburgee1 closed 4 years ago

macburgee1 commented 4 years ago

image

Fields:

Section title will be set in Layout Builder section settings.

macburgee1 commented 4 years ago

This issue is blocked by #99.

Remaining tasks:

macburgee1 commented 4 years ago

Note: the Accordion styling above was developmental in DCF and is not in production. The styling observed when reviewing this pull request will be consistent with the current DCF release.

ericras commented 4 years ago

This block type has a contextual edit button (?) - https://github.com/unlcms/project-herbie/pull/90#issuecomment-519644660

macburgee1 commented 4 years ago

The Inline Block Title Automatic module has been added in #90, so when that PR is merged, I'll rework this PR. I'm good with creating a new field. That will give us the flexibility to name it within the context of its use (e.g. Headline vs Title).

Re contextual link, that's correct. I didn't remove {{ title_prefix }} and {{ title_suffix }} from block--block_content-accordion--full.html.twig like I did with the Card block template file, so the Accordion block's contextual links didn't break.

Note to self: Remove view-mode designator for Accordion block template.

macburgee1 commented 4 years ago

Blocked by #90

macburgee1 commented 4 years ago

This PR has been updated and is ready to be reviewed.