unldenis / holoeasy

a simple and modern Java and Kotlin minecraft hologram library for 1.8-1.20.4 servers.
https://unldenis.github.io/holoeasy/
GNU Lesser General Public License v3.0
86 stars 26 forks source link

fixed issues with VersionUtil on 1.18.2 #13

Closed its-c10 closed 2 years ago

its-c10 commented 2 years ago

I'm using the library on 1.18.2. I was getting the IllegalArgumentException in VersionUtil line 58 (When it was using VersionEnum#valueOf). The string that was being passed through was "v1.18" instead of "V1.18". Fixed this by ensuring that the string is always uppercased. Also fixed VersionEnum 1.19 constant (Changed from "v1.19" to "V1.19" to mimic the rest of the constants)

unldenis commented 2 years ago

LGTM