unldenis / holoeasy

a simple and modern Java and Kotlin minecraft hologram library for 1.8-1.20.4 servers.
https://unldenis.github.io/holoeasy/
GNU Lesser General Public License v3.0
86 stars 26 forks source link

Separating Packets and Reintroducing HologramBuilder #33

Closed BadAccuracyID closed 1 year ago

BadAccuracyID commented 1 year ago

Packet Separation for Versions 1.9-1.18

In order to address the significant differences in packets between the 1.9-1.12 and 1.13-1.18 versions, I have now divided them into two distinct categories. This separation ensures better compatibility and prevents client crashes, particularly when testing the library on a 1.12 server.

Fixes:

To improve the stability and functionality of the library, the following fixes have been implemented:

Reintroduction of HologramBuilder

I have reintroduced the HologramBuilder. This reintroduction simplifies the process, making it more user-friendly, especially for simple/basic hologram implementations.

Please note that the commits made on April 16, 2023, can be disregarded. Originally, I intended to keep my fork private, but after resolving the bugs, I decided to make this Pull Request to contribute back to the main repository.

unldenis commented 1 year ago

Meanwhile, thanks for the work, in fact from the latest updates has increased the quality of the codebase but also the difficulty for the use of holograms. I leave you notes of some things I would add/modify.

BadAccuracyID commented 1 year ago

Thanks for the review and I've updated it now!

unldenis commented 1 year ago

LGTM ty.