unlearning-challenge / starting-kit

Starting kit for the NeurIPS 2023 unlearning challenge
https://unlearning-challenge.github.io/
Apache License 2.0
375 stars 133 forks source link

suggested fix to comment on losses histogram of the pre-trained model. #2

Closed AmrKhalifa closed 1 year ago

AmrKhalifa commented 1 year ago

The comment after the plot of histogram of losses on train vs test set of the pre-trained model (first plot) says: "As per the above plot, the distributions of losses are quite different between the forget and retain set. This suggests that the simple MIA that we're considering should be reasonably effective."

I believe this should be changed to: "As per the above plot, the distributions of losses are quite different between the train and test set. This suggests that the simple MIA that we're considering should be reasonably effective."

eleniTriantafillou commented 1 year ago

Indeed, great catch Amr, that was a typo. I've updated the notebook accordingly, and added some further clarifications :)

On Tue, Jun 27, 2023 at 11:43 PM Amr Khalifa @.***> wrote:

The comment after the plot of histogram of losses on train vs test set of the pre-trained model (first plot) says: "As per the above plot, the distributions of losses are quite different between the forget and retain set. This suggests that the simple MIA that we're considering should be reasonably effective."

I believe this should be changed to: "As per the above plot, the distributions of losses are quite different between the train and test set. This suggests that the simple MIA that we're considering should be reasonably effective."

— Reply to this email directly, view it on GitHub https://github.com/unlearning-challenge/starting-kit/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3R53JTKUHR7BRF4LMVV6LXNNO2NANCNFSM6AAAAAAZWHIYLE . You are receiving this because you are subscribed to this thread.Message ID: @.***>