unlhcc / HCCGo

A GUI application for submitting and managing jobs at the Holland Computing Center
5 stars 4 forks source link

Capture error if the job submission failed #155

Open djw8605 opened 7 years ago

djw8605 commented 7 years ago

If the job submission failed, capture the information.

a-weiss-programmer commented 7 years ago

Capturing the stderr is good enough, may possibly need to rework the runCommand

cjkeilig commented 7 years ago

We are logging ($log) the stderr of the 'sbatch' command on line 242 of ConnectionService, do we need to move this to the job submission async callback, or make a call to analytics?

djw8605 commented 7 years ago

It's ok to log it. But, it should also be sent back in the promise. Along with the exit code.

-Derek

On Mar 6, 2017, at 8:55 AM, cjkeilig notifications@github.com wrote:

We are logging ($log) the stderr of the 'sbatch' command on line 242 of ConnectionService, do we need to move this to the job submission async callback, or make a call to analytics?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.