search

unlhcc / HCCGo

A GUI application for submitting and managing jobs at the Holland Computing Center
5 stars 4 forks source link

File Manage & NavBar servicers #187

Closed jerroddixon closed 7 years ago

jerroddixon commented 7 years ago

Control functionality for file management and navbar put in services to preserve code run state, allowing behind the scenes upload and download functionality and preventing the username from flashing on redirects.

djw8605 commented 7 years ago

This is how the transfer screen looks for me: image

The 2 sides look weird. Can you label the 2 sides "Local" and "Remote" with like

or similar.

djw8605 commented 7 years ago

FWIW, I really like the navbar and file transfer as services. Seems so much faster!

Though, startup is getting to be a bit long. I wonder if we should have a splash screen.

jerroddixon commented 7 years ago

Merged your pull request and addressed the cosmetic changes. Something along these lines? hccgo_titles

djw8605 commented 7 years ago

Try putting the headers inside the gray area.

-Derek

On Feb 13, 2017, at 9:37 PM, Jerrod Dixon notifications@github.com wrote:

Merged your pull request and addressed the cosmetic changes. Something along these lines?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

jerroddixon commented 7 years ago

Oh and yes, I agree! The app feels a lot more responsive now. I'm not sure on a splash screen, maybe some sort of notification of 'setting up connection' would be helpful though

jerroddixon commented 7 years ago

How about this? hccgo_titles

djw8605 commented 7 years ago

Yes, that looks better. 2 more things.

  1. Could you remove the "working directory" text and just show the path.
  2. Could you put everything in <div> with bootstrap columns? So it doesn't get resized weird and different each time?
jerroddixon commented 7 years ago

I made the changes requested, page looks like the following hccgo_cosmetics

djw8605 commented 7 years ago

I think it looks great!

I'm trying to transfer a rather large directory, with lots of directories. It seems to get stuck after creating 3 directories?

image

No relevant errors.

djw8605 commented 7 years ago

My mistake, it was after a lot of directories have been completed. Possibly all of them. Now, it appears to be just sitting there.

jerroddixon commented 7 years ago

Hmm, for some reason when creating the folders it's creating a lot of folders in the top level directory instead of nested ones, with its name being where it's supposed to exist. Confused on this, as nothing of what I've changed should have affected the code in ConnectionService. Have there been any pushes to that file lately?

djw8605 commented 7 years ago

Not sure. I don't think there's been any changes to the mkdir functions.

jerroddixon commented 7 years ago

Think I figured it out, somewhere the '/' characters are getting changed into '\' characters and so the file system takes them as parts of the file name string, not as where they're supposed to exist in the filesystem.

jerroddixon commented 7 years ago

There, give that a try

jerroddixon commented 7 years ago

Noticed a graphical oops with the progress bar, most recent commit fixes that though.

djw8605 commented 7 years ago

I just tested on windows. Seems to work. Are you done with this pull request?

jerroddixon commented 7 years ago

Nearly, I tested on upload with windows and it works, but I ran into an issue retesting with download. I should have a resolution here soon

jerroddixon commented 7 years ago

That should resolve it. @djw8605 this should finalize this pull