search

unlhcc / HCCGo

A GUI application for submitting and managing jobs at the Holland Computing Center
5 stars 4 forks source link

Able to view a file. #227

Closed a-weiss-programmer closed 7 years ago

a-weiss-programmer commented 7 years ago

Addresses #221. Need some suggestions for how to delete the directory. I'm thinking about just using the shell to delete the directory when the app closes.

djw8605 commented 7 years ago

There's gotta be a way to use ng-disabled instead of setting a CSS.

a-weiss-programmer commented 7 years ago

Do you think we should change those css modifications to be booleans that are set instead?

a-weiss-programmer commented 7 years ago

so that we can use ng-disabled?

djw8605 commented 7 years ago

Nope, still lots of spacing issues :)

a-weiss-programmer commented 7 years ago

Ugh... I went through the entire file and did the spacing... does it really matter that much?

djw8605 commented 7 years ago

As long as everything still works, download, upload, and view. But if anything breaks, git blame is going to blame you rather than Jerrod :)

-Derek

On Mar 22, 2017, at 3:48 PM, caseylargent notifications@github.com wrote:

Ugh... I went through the entire file and did the spacing... does it really matter that much?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

djw8605 commented 7 years ago

Oh, and 1 more thing. It needs some sort of progress bar. Downloading / opening... It needs some feedback to the user when you click on "view". If it's a larger file, it may take a few seconds for anything to show up.

a-weiss-programmer commented 7 years ago

I don't know if we would necessarily need a progress bar for the dowloading/opening, but instead should be some spinning image in my opinion. Mostly because the progress bar would move decently fast fi all the logic for increasing the bar is placed within the file management js file

djw8605 commented 7 years ago

I like a progress bar because it actually shows the progress of the download. You can do whatever, but it needs some sort of feedback.

djw8605 commented 7 years ago

I like the rotating circle. Though, I'm worried about the timing of the file removal. I tried opening a file with a .slurm ending, which obviously didn't have a file association. By the time I selected the textedit application to open, it had already been removed and textedit failed.

I think the tmp package will automatically delete the file. Lets let it do the deleting.