search

unlhcc / HCCGo

A GUI application for submitting and managing jobs at the Holland Computing Center
5 stars 4 forks source link

Change title to reflect what page the user is on. #235

Closed a-weiss-programmer closed 7 years ago

a-weiss-programmer commented 7 years ago

Addresses #11

djw8605 commented 7 years ago

Why is it failing the build tests?

-Derek

On Mar 27, 2017, at 4:37 PM, caseylargent notifications@github.com wrote:

Addresses #11

You can view, comment on, or merge this pull request online at:

https://github.com/unlhcc/HCCGo/pull/235

Commit Summary

Change title to reflect what page the user is on. File Changes

M HCCGo/app/html/navbar.html (2) M HCCGo/app/js/navService.js (7) Patch Links:

https://github.com/unlhcc/HCCGo/pull/235.patch https://github.com/unlhcc/HCCGo/pull/235.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

djw8605 commented 7 years ago

You can't use angular.element to select the title. Really, you should be using {{ title }} and then bind the title from the controller to the service.

djw8605 commented 7 years ago

Awesome! does this all work?

a-weiss-programmer commented 7 years ago

Yep! I will accept any and all git blame :)

djw8605 commented 7 years ago

I think this will lead to the side panel being much more useful!