Added data to the notification

[adamfitzgibbon]

addresses #155

[djw8605]

Does the runCommand actually return stderr? Or just stdout?

[adamfitzgibbon]

Isn't stderr piped to stdout when a command directly fails?

[djw8605]

I don't think so. I think the runCommand has to do it:

 }).on('data', function(data) {
      console.log('STDOUT: ' + data);
    }).stderr.on('data', function(data) {
      console.log('STDERR: ' + data);
    });

[adamfitzgibbon]

Is that meant to be chained onto the push function in runCommand?

[adamfitzgibbon]

It looks like it already rejects and spits out an error, so any command using runCommand should be able to just chain a failure function to get that the error text.

if (err) {
              deferred.reject("Error running command " + command + ": " + err);
          } else {
              deferred.resolve(cumulData);
          }

[djw8605]

No. It needs to be on the exec in the run command queue.

-Derek

On Apr 25, 2017, at 4:25 PM, Adam Fitzgibbon notifications@github.com wrote:

Is that meant to be chained onto the push function in runCommand?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.