search

unlobito / ha-hildebrandglow

PRE-RELEASE. HomeAssistant integration for the Hildebrand Glow smart meter HAN for UK SMETS meters.
MIT License
54 stars 32 forks source link

Use classifiers instead of resource type IDs #23

Closed technofreak74 closed 3 years ago

technofreak74 commented 3 years ago

Use the resource's classifier instead of the resourceTypeID that appears to differ between suppliers / data collection method. As per https://github.com/unlobito/ha-hildebrandglow/issues/19#issuecomment-782872063 (and the linked documentation). I think this should resolve #19 ?. I realise that this is a stop gap until the project switches over to MQTT but it'd be nice to have it working until that is ready!

It created gas and electricity sensors for CAD data attached to some EDF meters in the UK. Electricity seems to be instantaneous usage and gas is actually the meter reading but I think that is a separate issue :smiley:

technofreak74 commented 3 years ago

The CI failed on unrelated changes :(

unlobito commented 3 years ago

Hey @technofreak74 👋 Thanks for submitting this PR! I really appreciate it.

I'm taking a look at the CI failure now and will get back to you on this in a minute.

unlobito commented 3 years ago

Bam 🎉 It seems the typedefs in home-assistant changed a bit, but your PR passes CI just fine with those fixes out of the way.

Thanks again for this pull request :)

technofreak74 commented 3 years ago

Cool, thanks for looking into that so quickly! (and accepting my PR).