search

unlobito / skunk

Easy access to your store cards and other barcodes from your Pebble.
Other
29 stars 14 forks source link

Supports Chalk and Aplite on OS 3. Drops support of Aplite on OS 2. #20

Closed CocoaBob closed 8 years ago

CocoaBob commented 8 years ago

Great! Thanks!

unlobito commented 8 years ago

Hey @CocoaBob,

I really appreciate your contribution to the project and have pushed this pull request out as version 1.4.

Thanks again for the awesome work. (:

CocoaBob commented 8 years ago

You are welcome! Skunk is the best bar code app in the Appstore, and I'm glad that it's open source :)

Actually I didn't test it on Aplite/Basalt platforms as I didn't figure out how to open the Configuration Page in emulators...

And my friend has another question that why the number of codes is limited to only 8? I noticed that it's limited by Configuration Page's JS script, so I can't change it.

unlobito commented 8 years ago

I was able to test your code on Aplite and Basalt using real hardware and can confirm that everything is functioning as expected.

skunk is limited to 8 barcodes through skunk-config due to limited storage space available through the persistent storage APIs. Apps are allowed 4kB of data, with maximum data lengths of 256 bytes (256B * 8 = 4kB). This limit could possibly be raised by calculating each barcode's size beforehand, but this might lead to too much complexity.

CocoaBob commented 8 years ago

Hi, I think QR code is much larger than bar code, if we can store 8 QR codes, I suppose we can store many more bar codes? And 4096 B = 256 B x 16. But I'm not sure if 256B (2048b) is enough for a QR code? I will check the codes later when I have time, it might be more complex than what I thought... Thanks for you answer :)