unlobito / skunk

Easy access to your store cards and other barcodes from your Pebble.
Other
29 stars 14 forks source link

Line barcode a bit too small #8

Open jamesweech opened 9 years ago

jamesweech commented 9 years ago

I noticed with my tesco clubcard seems awfully hard to scan due to the fact the barcode does not stretch the entire area but uses a set height

unlobito commented 9 years ago

How long is your Tesco clubcard barcode and what type of barcode is it?

jamesweech commented 9 years ago

15 numbers long code 128

Thanks

jamesweech commented 9 years ago

also I noticed my barcode goes to the very end pixel of the screen making it impossible to scan as tried today (very embarrassing at tescos self service when you are waving your watch in front of the scanner like a lunatic for a few with a line behind you haha)

unlobito commented 9 years ago

The only real fix for this is to display the barcode vertically in order to give it more screen space.

Thanks for the report.

jamesweech commented 9 years ago

thanks, also you might want to define a border since if the barcode takes all the watch it is not able to be scanned (I tested on a amazon locker today and after a few minutes gave up)

tackynugget commented 8 years ago

+1 for this request. I love the app and use it all the time. If the scan area/image were larger, it'd help a lot. I made a barcode watch face that is larger and in vertical orientation that scans well, but isn't as convenient as this app.

ajlowndes commented 7 years ago

+1 again. Here in Australia I'm having trouble scanning my flybuys card on my pebble 2. EAN-13 barcode, 13digits. Plenty of white space on either side of the screen, if you could have the option to scale up the barcode to use (almost) the full screen width, that would be ideal. Vertically? Even better...

ajlowndes commented 7 years ago

Hey @henriwatson, I fiddled around a bit and found that making the SCALING_FACTOR a float value instead of int16_t, meant that I could assign a multiple of 0.5 rather than an integer. With a value of 1.5, my barcode rendered correctly and used up the whole screen. Not sure how to implement it properly though (I'm no proper programmer, just like to fiddle)

    //const int16_t SCALING_FACTOR = MAX( SCALING_FACTOR_X, 1);
    const float SCALING_FACTOR = 1.5;

the fact that my barcode touches the RHS side of the screen without a 1px gap doesn't seem to be a problem in my case - at least my test software on the phone seemed to scan it fine.