Accounts - Githubissues

unlock-protocol / locked.fyi

A basic notes application where notes are stored on IPFS and only visible by members of a lock

https://locked.fyi/

MIT License

21 stars 7 forks source link

Accounts #42

Open julien51 opened 4 years ago

julien51 commented 4 years ago

We currently require an injected wallet... which is very annoying because only a very small fraction of web users have an injected wallet. We need to support the following:

If there is an injected wallet, default to that one, but let users pick another one.
If there is no injected wallet, let the user use something like WalletConnect to connect their other existing wallet, or use a "hosted wallet" such as Fortmatic or Portis or Bitski.

julien51 commented 4 years ago

It looks like https://github.com/aragon/use-wallet provides the exact level of abstraction/customization that were looking for.

julien51 commented 4 years ago

After diving a bit deeper it looks https://github.com/NoahZinsmeister/web3-react (on which use-wallet is built) is both more maintained and richer so that's what we're using!

julien51 commented 4 years ago

We now use @web3-react with the injected connector. Next, we need to add support for WalletConnect and for Magic by Fortmatic: https://github.com/NoahZinsmeister/web3-react/issues/101