search

unlock-protocol / locked.fyi

A basic notes application where notes are stored on IPFS and only visible by members of a lock
https://locked.fyi/
MIT License
21 stars 7 forks source link

DAO shares minting concerns #57

Closed nfurfaro closed 3 years ago

nfurfaro commented 3 years ago

1.) Currently, all key purchases will trigger the hook. This means that a new key purchase will end up triggering the dao to mint a token for the author, but so will a key purchase which is just topping up an existing key, even if the purchase is made immediately after a previous purchase.

2.) If someone calls purchase directly (ie:through etherscan) they could pass an address they control as the author address, and do this repeatedly. They would still be paying for keys/key-extensions but would be receiving dao shares in return.

nfurfaro commented 3 years ago

Thinking about this some more, I'm not certain that .2) above is actually an issue.