search

unlock-protocol / unlock

Ʉnlock is a protocol for memberships built on a blockchain.
https://unlock-protocol.com
MIT License
827 stars 239 forks source link

Add Mint Date to NFT Metadata #10599

Open blastchat opened 1 year ago

blastchat commented 1 year ago

Is your feature request related to a problem? Please describe.

We want to display our members "joined date" to the NFT's metadata as a sign of clout. Ex: The earlier you join the community the more clout you will have in our community.

@julien51

julien51 commented 1 year ago

Thanks a loyt @blastchat ! W'll get started on this!

blastchat commented 1 year ago

@julien51 any luck or progress on this? Lol

julien51 commented 1 year ago

Sorry for the delay here. We now have the createdAt and createdAtBlock in the subgraph so I believe it should be fairly easy to build.

I will add a bounty tag to this one.

blastchat commented 1 year ago

Thank you Julien!

On Tue, Jul 18, 2023 at 5:33 AM Julien Genestoux @.***> wrote:

Sorry for the delay here. We now have the createdAt and createdAtBlock in the subgraph so I believe it should be fairly easy to build.

I will add a bounty tag to this one.

— Reply to this email directly, view it on GitHub https://github.com/unlock-protocol/unlock/issues/10599#issuecomment-1639876992, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6RAN4IMHEDFXWE6GFSWRLXQZJ6ZANCNFSM6AAAAAATBOHACM . You are receiving this because you were mentioned.Message ID: @.***>

iMac7 commented 2 months ago

@julien51 the nft here refers to the key, right? I'd like to work on this

blastchat commented 2 months ago

That would be amazing @iMac7

julien51 commented 2 months ago

@iMac7 Let's go for it! Please add the mintedAt value in the subgraph for each key (yes that is the NFT). Once it is in the subgraph, please check the locksmith calls that renders the metadata to make sure this is "served" as well. (as an attribute).

We are attaching 250 USDC because this includes 2 significant changes (subgraphs + locksmith)

iMac7 commented 1 month ago

Please add the mintedAt value in the subgraph for each key

@julien51 since there is already createdAt in the subgraph, will mintedAt have the same functionality but with a different name? Will there also be changes in unlock-app to display the minted date somewhere?

julien51 commented 1 month ago

@julien51 since there is already createdAt in the subgraph, will mintedAt have the same functionality but with a different name?

Ha! you are correct, we already have createdAtso we do not need mintedAt in the subgraph... we just need to expose it in the metadata i locksmith...

julien51 commented 1 month ago

@iMac7 do you mind posting the address I should use for the payment here? Thanks!

iMac7 commented 1 month ago

0x88751a1a1fCC8ae52a9eE596e9B6B5b26409e562