search

unlock-protocol / unlock

Ʉnlock is a protocol for memberships built on a blockchain.
https://unlock-protocol.com
MIT License
828 stars 242 forks source link

Receipt created on Grant Key Extension #13437

Open SVell opened 5 months ago

SVell commented 5 months ago

Describe the bug Subgraph creates a receipt on Grant Key Extension

To Reproduce

  1. Purchase a Key
  2. Cancel or Refund this Key
  3. As a lock manager extend the key
  4. Check receipts page

Expected behavior Receipt should not be created on extend without value

Screenshots image image

julien51 commented 5 months ago

That's a good one! do you want to work on it pleasE?

SVell commented 4 months ago

The value of tx is not 0, although it is 0 that's why createReceipt works for this tx. Possible solution to modify createReceipt to dig into tx logs https://sepolia.etherscan.io/tx/0xd0a78935acc2882971d069cd97314a183a56d4edeb62a3fa22c78b1c4c47ea5b https://sepolia.etherscan.io/tx/0xbd33d52328ade3603ec40b071f30654b3e6f8f1c28f404eeafb34fc1efaec8fb