search

unlock-protocol / unlock

Ʉnlock is a protocol for memberships built on a blockchain.
https://unlock-protocol.com
MIT License
835 stars 244 forks source link

Protocol health check zkSync, zkEVM, Scroll #13505

Closed julien51 closed 6 months ago

julien51 commented 6 months ago

It looks like these are currently now setup correctly based on the healthcheck output:

Running task for the following networks: arbitrum,avalanche,base,bsc,celo,gnosis,goerli,linea,mainnet,mumbai,optimism,polygon,scroll,sepolia,zkevm,zksync
[Ethereum]: ⚠️  Unlock owner is not the team multisig (0x9168EABE624e9515f3836bA1716EC1DDd4C461D4)!
[Scroll]: ⚠️  ERROR: Failed to fetch ProxyAdmin address
[Scroll]: ⚠️  Unlock contract and ProxyAdmin have different owners!
[zkEVM (Polygon)]: ⚠️  ERROR: Failed to fetch ProxyAdmin address
[zkEVM (Polygon)]: ⚠️  Unlock contract and ProxyAdmin have different owners!
[zkSync Era]: ⚠️  ERROR: Failed to fetch ProxyAdmin address
[zkSync Era]: ⚠️  Unlock contract and ProxyAdmin have different owners!
[zkSync Era]: ⚠️  Unlock owner is not the team multisig (0xFa5592CE9C52FA5214ccEa10cB72Faa88eC80a3c)!
clemsos commented 6 months ago

fixed the way proxy admin address is fetched in #13517 and transferred ownership of zksync contracts to team multisig

julien51 commented 6 months ago

Thanks! It looks like we still have an issue with Scroll

Error HH110: Invalid JSON-RPC response received: Something went wrong! Team has been notified.

For more info go to https://hardhat.org/HH110 or run Hardhat with --show-stack-traces
node:child_process:965
    throw err;
    ^

Error: Command failed: yarn hardhat --network scroll unlock:info --quiet
    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at Object.<anonymous> (/Users/julien/repos/unlock/governance/all_networks:30:3)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 87139,
  stdout: null,
  stderr: null
}
julien51 commented 6 months ago

All good!

yarn run check                     
Running task for the following networks: arbitrum,avalanche,base,bsc,celo,gnosis,linea,mainnet,mumbai,optimism,polygon,scroll,sepolia,zkevm,zksync
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
[Ethereum]: ⚠️  ProxyAdmin owner is not the team multisig
[Ethereum]: ⚠️  Unlock owner is not the team multisig
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.

We will need to take care of warning on mainnet eventually!