unlock-protocol / unlock

Ʉnlock is a protocol for memberships built on a blockchain.
https://unlock-protocol.com
MIT License
834 stars 244 forks source link

Make sure that storeTransaction for StorageService is idempotent #1426

Closed julien51 closed 5 years ago

julien51 commented 5 years ago

Based on our current architecture it is possible that the same transaction may be sent to storage multiple times. Locksmith should handle that gracefuly and just ignore subsequent storeTransaction when it already has a transaction for the same hash.

akeem commented 5 years ago

@julien51 this should already return a 400, are you experiencing different behavior here?

akeem commented 5 years ago

Closing as this was addressed with the release of #1544