Closed cnasc closed 5 years ago
@cnasc do you want to take the reins on deciding a limited way we can test this? Or lead an experiment? Part of this will be consulting with @julien51 to determine the priority and when this should be considered
I am 100% willing to take the reins on an experiment for this.
Here's what I propose:
any
type. In fact, we can probably do this module-by-module, so that as each module gets typed, we also clamp down the rules so that no new dynamically typed code sneaks in.To "experimentify" that, I think step 1 needs to be done in its entirety. Then we can fetch types for third-party libraries and then move to implementing some of our own code.
@cnasc works for me. Let's focus on the unlock-app
for now on this one since it probably has less moving part (despite being bigger!).
Let's do 1. and reconvene before you attack 2.
Just to confirm:
unlock-app
projectunlock-app
build in its current state with tsc
and associated toolingI think at this point we have decided what the path forward is for TypeScript, and given that today I should merge TS support for both unlock-app
and locksmith
, I think we can close this issue.
We need to determine if we are going to use TypeScript when we spin off the paywall app, and how we will use it if we do.