unlock-protocol / unlock

Ʉnlock is a protocol for memberships built on a blockchain.
https://unlock-protocol.com
MIT License
819 stars 238 forks source link

An in-range update of zos is breaking the build 🚨 #1530

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency zos was updated from 2.1.2 to 2.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

zos is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **Travis CI - Branch:** The build **failed**.

Release Notes for v.2.2.0

Added

  • Contributing guidelines (#553)
  • New ProxyAdmin contract to manage proxy instances (#588 and #625) (see audit report)
  • Example using truffle migrations (#416)
  • Tests for verify command (#468)
  • Migration process for projects using previous versions of ZeppelinOS v2 (#621)
  • Support receiving booleans via the CLI (#623)
  • Parse scientific notation numbers from the CLI (#567)
  • Linter pre-commit githook (#620)

Changed

Fixed

  • Gas estimation issues on geth (#614)
  • Use gas defaults when present (#575)
  • Bytecode comparison in SimpleProject (#580)
  • Avoid changing tx params object for every transaction (#675)
  • Force compiling all contracts (#581)
  • Etherscan mainnet url (#642)
  • Checksum default sender address on initialization (#654)
  • Ignore Truffle's default gas value (#671)
  • Integration tests using truffle-hdwallet-provider (#473)

Removed

  • truffle-contracts from codebase (#451)
  • truffle-resolver from CLI and honor from in config (#612)
  • Lightweight terminology (#550)
FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

HardlyDifficult commented 5 years ago

This is a non-trivial upgrade. ZOS changed with 2.2 and now requires we modify some init code - specifically ZWeb and artifacts changed (maybe more).

julien51 commented 5 years ago

:(

HardlyDifficult commented 5 years ago

They are still working on documentation, so in interest of time I suggest we just wait until details are clarified.

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v2.2.1

This patch release includes several bugfixes, but the main change is the removal of openzeppelin-solidity as a dependency. This allows users of zos-lib to be able to use whichever version of openzeppelin they want, since truffle compilation fails to handle multiple versions of the same package in the same project (including transitive dependencies).

Changed

  • Remove openzeppelin-solidity as a dependency (#739)

Fixed

  • Provider initialization issue on zos check command (#737)
  • Error messages that refer to truffle.js config file when actually it is truffle-config.js (#710)
  • Error message "Cannot read zosversion of undefined" when attempting to create a contract on a new network that had not been push'ed to before (#711)
  • Handle spaces in project path when compiling contracts (#743)
HardlyDifficult commented 5 years ago

Done