unlock-protocol / unlock

Ι„nlock is a protocol for memberships built on a blockchain.
https://unlock-protocol.com
MIT License
839 stars 248 forks source link

An in-range update of react-testing-library is breaking the build 🚨 #2255

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency react-testing-library was updated from 6.0.1 to 6.0.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

react-testing-library is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - βœ… **ci/circleci: checkout-and-cache:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/unlock-protocol/unlock/13145?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: build-unlock-integration:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/unlock-protocol/unlock/13149?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: build-unlock:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/unlock-protocol/unlock/13148?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: wedlocks-tests:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/unlock-protocol/unlock/13181?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: locksmith-tests:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/unlock-protocol/unlock/13185?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/chromatic:** 246 stories unchanged. ([Details](https://www.chromaticqa.com/build?appId=5c7d369cd530c00020ea8e0e&number=736)). - βœ… **ci/circleci: unlock-app-chromatic:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/unlock-protocol/unlock/13183?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: unlock-app-tests:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/unlock-protocol/unlock/13179?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: smart-contracts-tests:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/unlock-protocol/unlock/13184?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **ci/circleci: paywall-tests:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/unlock-protocol/unlock/13182?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: integration-tests:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/unlock-protocol/unlock/13180?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **build-test-and-deploy:** * [checkout-and-cache](https://circleci.com/gh/unlock-protocol/unlock/13145?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Success * [build-unlock-integration](https://circleci.com/gh/unlock-protocol/unlock/13149?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Success * [build-unlock](https://circleci.com/gh/unlock-protocol/unlock/13148?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Success * [smart-contracts-tests](https://circleci.com/gh/unlock-protocol/unlock/13184?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Success * [paywall-tests](https://circleci.com/gh/unlock-protocol/unlock/13182?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Success * [unlock-app-chromatic](https://circleci.com/gh/unlock-protocol/unlock/13183?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Success * [integration-tests](https://circleci.com/gh/unlock-protocol/unlock/13180?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Failed * [locksmith-tests](https://circleci.com/gh/unlock-protocol/unlock/13185?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Success * [unlock-app-tests](https://circleci.com/gh/unlock-protocol/unlock/13179?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Failed * [wedlocks-tests](https://circleci.com/gh/unlock-protocol/unlock/13181?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Success * deploy-paywall-netlify - Blocked * deploy-unlock-app-netlify - Blocked

Release Notes for v6.0.2

6.0.2 (2019-03-21)

Bug Fixes

Commits

The new version differs by 3 commits.

  • ea3ef2f docs: add pschyma as a contributor (#332)
  • aed35f4 fix(TS): update Typings (#331)
  • 4302cdd docs: add example for react intl (#329)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

cellog commented 5 years ago

looks like their typing changes affected us

cnasc commented 5 years ago

I'm skeptical that the types did it, since none of the failures come from TS files (and I think none of the files that use rtl are TS either). The issue could have been introduced in 6.0.1? We're still on 6.0.0

cnasc commented 5 years ago

6.0.1 indeed introduced the failures. Manually installed @6.0.1 and got exactly the same output as above.

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v6.0.3

6.0.3 (2019-03-26)

Bug Fixes

  • deps: upgrade all dependencies (a33ccf8)
Commits

The new version differs by 1 commits.

  • a33ccf8 fix(deps): upgrade all dependencies

See the full diff