unlockopen / www.unlockopen.com-v4

V4 of the UnlockOpen website
0 stars 1 forks source link

Fix md images #22

Closed madrilene closed 6 months ago

madrilene commented 6 months ago
netlify[bot] commented 6 months ago

Deploy Preview for unlockopen-com-v4 ready!

Name Link
Latest commit eb659b5ac791ae519674968be7a6a44c441e54cb
Latest deploy log https://app.netlify.com/sites/unlockopen-com-v4/deploys/65e6eccdde309c00087618c5
Deploy Preview https://deploy-preview-22--unlockopen-com-v4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

madrilene commented 6 months ago
tobie commented 6 months ago
  • Updating markdown-it-eleventy-img (forked) solved the issue. I filed an issue for the plugin author so they are aware. For now my own fork is referenced.

Please file an issue here (referencing the issue you created against upstream) to track the upstream repo and revert back to it once it is updated.

madrilene commented 6 months ago

Good to go once the comments are addressed and the relevant issues filed.

Do you prefer I open new PRs for changing things unrelated (OG images, prettier config)?

tobie commented 6 months ago

Do you prefer I open new PRs for changing things unrelated (OG images, prettier config)?

This PR is all over the place already so might as well add it here. Maybe rebase and merge instead of squashing, though.

madrilene commented 6 months ago

you're having a hard time with me! 😅

tobie commented 6 months ago

you're having a hard time with me! 😅

Nah, it's fine. It's normal for both of us to need to adjust our cultural norms/default expectations as we start collaborating.