unlockopen / www.unlockopen.com-v4

V4 of the UnlockOpen website
0 stars 1 forks source link

Cleanup asset metadata management #29

Closed tobie closed 5 months ago

tobie commented 6 months ago

This cleans-up asset metadata and extends it to article images.

The metadata includes alt, attribution, and caption info. This info is automatically integrated with both shortcode and markdown images. It can be overwritten locally. This is particularly useful for caption that tends to be context-dependent.

As a result:

Still todo:

netlify[bot] commented 6 months ago

Deploy Preview for unlockopen-com-v4 ready!

Name Link
Latest commit 8aa367e33f6b350cc42da18daa6ae47276e46b56
Latest deploy log https://app.netlify.com/sites/unlockopen-com-v4/deploys/65f07df0678c9c000935645f
Deploy Preview https://deploy-preview-29--unlockopen-com-v4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

madrilene commented 5 months ago

I don't know whether you attach importance to this or prefer not to do it, but I would place image-attribution.js in _eleventy/utils according to the classification system, and also import embedTwitter via the plugins-folder.

tobie commented 5 months ago

I don't know whether you attach importance to this or prefer not to do it, but I would place image-attribution.js in _eleventy/utils according to the classification system

Makes sense!

and also import embedTwitter via the plugins-folder.

Sure thing. Want to push it in a separate PR, though?

tobie commented 5 months ago

So are you planning to do the refactoring for image-attribution here or elsewhere?

madrilene commented 5 months ago

Whatever you prefer! I found some other tiny issues, like outdated custom properties and an unused shortcode. Maybe I could collect them all in a separate PR?

tobie commented 5 months ago

That works