unlockopen / www.unlockopen.com-v4

V4 of the UnlockOpen website
0 stars 1 forks source link

Cleaning up config, removing outdated CSS #30

Closed madrilene closed 5 months ago

madrilene commented 5 months ago

Updates

Questions or Recommendations

netlify[bot] commented 5 months ago

Deploy Preview for unlockopen-com-v4 ready!

Name Link
Latest commit 5b44eaf31b90400abb1ea4c9e1c87b0dc40d9ef7
Latest deploy log https://app.netlify.com/sites/unlockopen-com-v4/deploys/65f4597ea0d08c0008629952
Deploy Preview https://deploy-preview-30--unlockopen-com-v4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tobie commented 5 months ago

About the inlineMarkdown hack where you want to remove the surrounding

tags - I'm not quite sure why we need that? Could it be that this is a leftover from another strategy? You use it in article.njk for example like this: <h1>{{ title | inlineMarkdown | safe }}</h1> And I'm not quite sure why?

To allow for markdown in titles.

How do you want to handle mobile menu behaviour? Wrap pills / drawer menu.

let’s discuss in a dedicated issue.

I plan to add a postcss plugin for color-mix that converts the values into hex colors, for unsupported browsers. Ok with that?

I’m entirely fine having a very degraded experience in older browsers as long as the content remains readable. I wouldn’t worry about these.

If we only use simple shapes like circles and rectangles, I would possibly use CSS instead of SVG for the so-called "decorative" elements.

svg’s fine.

madrilene commented 5 months ago

I have also made the "sun" change we discussed, both renaming it and assigning it to the speaking contents.