unloggedio / intellij-java-plugin

IntelliJ plugin with java language support
https://unlogged.io
Apache License 2.0
12 stars 1 forks source link

Improvement on automatic spam filter exclude #12

Open TheAmg opened 3 months ago

TheAmg commented 3 months ago

Describe the bug

On DirectInvoking a method that calls a 2nd method that generates enough candidates at once for it to be automatically excluded (from the same class), the filters are always set to exclude the current class. This will prevent candidates from other methods from the same class from showing up.

Example : DirectInvokeunlogged-spring-maven-demo -> RecursionController -> getFibonacciSeries(). Candidates for getFibonacciSeries will be excluded on clicking the inlay hint above the method due to the 109 candidates from fibonacci method. (input 10). Removing the entry in excluded class manually is necessary for this candidate to show up.

https://github.com/unloggedio/intellij-java-plugin/assets/68552461/00b66be5-934b-4396-aa6b-b9ee48a24e9a

Reproduction steps

  1. Start unlogged-spring-maven-demo
  2. DirectInvoke RecursionController -> getFibonacciSeries
  3. Try to save candidate for getFibonacciSeries

Expected behavior

The spam filter should ideally only filter out only the spammy method from that class and not all the methods from that class.

Additional context

No response