unmk2 / ovz-web-panel

Automatically exported from code.google.com/p/ovz-web-panel
Other
0 stars 0 forks source link

Wrong sorting for VEIDs in list, breaks auto-assignment of VEIDs #504

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The virtual server list is sorting the VEIDs in alphabetical order rather than 
numerical order, which makes 10 come after 1, instead of it coming after 9. See 
the first screenshot.

Besides the cosmetic issue, this faulty logic is also applied in container 
creation. In this case, where I have containers with the ID 9 and 10, if I try 
to create a virtual server and don't specify a VEID myself, OWP stubbornly 
keeps trying to add a container with ID 10 and fails, because it thinks 9 comes 
after 10. See second screenshot.

Original issue reported on code.google.com by miguelpontes on 19 Apr 2013 at 12:46

Attachments:

GoogleCodeExporter commented 9 years ago
This was caused by the last DB schema change, 
20130223060327_change_identity_type_in_virtual_server.rb, which changes the 
type of the identity column in virtual_servers column to string. What was the 
rationale behind this change? 

If you don't see any problems with changing it back, I've submitted a pull 
request that undoes this: https://github.com/sibprogrammer/owp/pull/28

Original comment by miguelpontes on 21 Apr 2013 at 1:54

GoogleCodeExporter commented 9 years ago
Fixed in 
https://github.com/sibprogrammer/owp/commit/9d1d235df109b790fe1bec3c5144c9ee6027
3b9e

Original comment by sibprogrammer on 24 Apr 2013 at 3:45