unmojang / FjordLauncher

Prism Launcher fork with support for alternative auth servers
GNU General Public License v3.0
78 stars 14 forks source link

vulkan mods don't work #19

Closed I-like-stuff closed 2 months ago

I-like-stuff commented 3 months ago

Operating System

Linux

Version of Fjord Launcher

Fjord Launcher 8.4

Version of Qt

Qt 6.7.2

Description of bug

if I run a different instance with the vulkanmod installed, I get this image

there was a way to tackle this in prismlauncher and the now dead pollymc which was to add "additional libs" and then insert "vulkan-loader" to fix the problem in Nixos however that doesn't seem to work here in fjord so I'm not sure

Steps to reproduce

install vulkanmod on any instance and you'll likely going to run in the same issue

Suspected cause

vulkan-loader isn't included as a dependency over in the fjord launcher nix package which is preventing me from adding it as an additional library

This issue is unique

i-can-not-program commented 3 months ago

there was a way to tackle this in prismlauncher and the now dead pollymc which was to add "additional libs" and then insert "vulkan-loader" to fix the problem in Nixos however that doesn't seem to work here in fjord so I'm not sure

It works for me with this:

fjordlauncher.override { additionalLibs = [ vulkan-loader ]; }

I don't think this should be added by default, since it is not required by the vanilla game and additional libraries can easily be added.

evan-goode commented 3 months ago

The prismlauncher derivation in nixpkgs has vulkan-loader as of https://github.com/NixOS/nixpkgs/pull/303880, but the derivation in Prism's upstream repository (and therefore Fjord's) doesn't. I'm happy to cherry-pick this in for now, and I'll ask upstream about keeping their derivation in sync with nixpkgs.

evan-goode commented 3 months ago

I filed https://github.com/PrismLauncher/PrismLauncher/pull/2667, let's wait for that.