search

unmojang / drasl

Yggdrasil-compatible API server for Minecraft
GNU General Public License v3.0
119 stars 20 forks source link

Drasl doesn't check for special characters in username #73

Closed IkyMax closed 6 months ago

IkyMax commented 6 months ago

As said in the title, Drasl doesn't check for valid usernames, it allows special characters such as ñ, æ, å, ę, ç and many others, it doesn't even check for spaces on characters usernames (test test) and it can happen what a space is set after the username (such as "test "), causing weird Issues on a Minecraft server.

evan-goode commented 6 months ago

Thanks, yeah you're right, the default should probably be to not allow "exotic" player names. I opened https://github.com/unmojang/drasl/pull/74.

IkyMax commented 6 months ago

Nice! Do you want me to test it?

evan-goode commented 6 months ago

Sure! Thanks

IkyMax commented 6 months ago

Hey! it works, thx! Will you be pushing this and the client token changes anytime soon into the docker image?

evan-goode commented 6 months ago

Fixed in https://github.com/unmojang/drasl/pull/74