search

unoconv / unoserver

MIT License
592 stars 81 forks source link

Introducing timeout and retrying mechanism #119

Closed HirotoKagotani closed 4 months ago

HirotoKagotani commented 6 months ago

I am using unoserver/unoconvert with Moodle LMS. (See MDL-75066) Moodle uses unoserver to convert assignment submission files into pdf. Students may submit various types of document files. LibreOffice (soffice.bin) sometimes keeps 100% CPU usage and XMLRPC never finishes depending on input file characteristics and/or some specific conditions.

My proposal is introducing timeout and retrying mechanism for such situation. On detecting timeout, unoserver may kill and restart LibreOffice within a certain limited number of times. On exceeding the number limit, unoserver may return an error.

Thank you and regards,

regebro commented 5 months ago

I think that could be a good feature to have, indeed.

regebro commented 4 months ago

Implemented in the latest version.