search

unode / firefox_decrypt

Firefox Decrypt is a tool to extract passwords from Mozilla (Firefox™, Waterfox™, Thunderbird®, SeaMonkey®) profiles
GNU General Public License v3.0
2k stars 303 forks source link

"Feature"-Request pyproject.tml and pypi #91

Closed NeffIsBack closed 1 year ago

NeffIsBack commented 1 year ago

Hi, this looks like a really cool tool. I would like to install this script using pipx, so it is in line with my other python tools. Would it be possible to provide a pyproject.toml file (and maybe upload it to pypi.org)?

If you don't want to deal with building the toml file i can open a PR if that is alright. Than it could be uploaded without much effort i think.

unode commented 1 year ago

Hi Alex,

firefox_decrypt has no dependencies beyond Python 3.9+ and standard library. As such it never made much sense to make it installable via pip/pipx.

Currently, installation means downloading the script from the main branch or from one of its tags/releases. Everything is included.

I'm happy to accept a pyproject.toml but it feels a bit overkill. For the same reason and it not being designed to be used as a library, I'm not sure about including it in pypi.

That said, I'm open to be convinced given a concrete use-case.

NeffIsBack commented 1 year ago

Yes I absolutely agree having a poetry/pyproject.toml doesn't really make sense for dependency management in a project with no dependencies😅 The point why it would be really nice to have one is because pipx would need one to make the tool installable.

My goal is to have every Pentest tool, that is either not available or outdated on apt (e.g. CrackMapExec, impacket) installed with pipx. That makes them available system wide on the command line and very easy to update (as soon as there is a version bump in the pyproject.toml I can run ‘pipx upgrade‘).

To have the tool on PyPI is just a nice addition, but installations directly from GitHub works just as well, so that wouldn't be absolutely necessary.