add support for System.Text.Json serialization - Githubissues

unoplatform / Uno.CodeGen

A set of source generators for equality, immutability, ...

Other

90 stars 11 forks source link

add support for System.Text.Json serialization #125

Closed beppemarazzi closed 4 years ago

beppemarazzi commented 4 years ago

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

.NET Core 3.0 has a new API for json serialization (see https://devblogs.microsoft.com/dotnet/try-the-new-system-text-json-apis/) but it's not supported by Uno.Immutables...

What is the new behavior?

System.Text.Json API is supported exactly like the well known Newtonsoft.Json

PR Checklist

Please check if your PR fulfills the following requirements:

[X] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[X] Tests for the changes have been added (for bug fixes / features) (if applicable)
[X] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

gitpod-io[bot] commented 4 years ago

carldebilly commented 4 years ago

Wow you're very motivated!

You'll need to update the documentation to reflect this new feature.
Would also be good to find a way to test when the feature is disabled to ensure it's behaving properly. Also it's running well on older version of .net/.netcore without the support for those APIs.