Append line terminator in IndentedStringBuilder.AppendLine (#55)

[gahag]

Corresponding to the behavior of .net's StringBuilder, the method AppendLine should append a line terminator at the end.

GitHub Issue (If applicable): #55

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

AppendLine(String) does not insert a new line at the end.

What is the new behavior?

AppendLine(String) does inserts a new line at the end.

PR Checklist

Please check if your PR fulfills the following requirements:

• [x] Tested code with current supported SDKs
• [x] Docs have been added/updated which fit documentation template. (for bug fixes / features)
• [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
• [ ] Contains NO breaking changes
• [x] Updated the Release Notes
• [x] Associated with an issue (GitHub or internal)

I believe this can be a breaking change, but I'm not sure how should we proceed regarding this matter. Also, I've not added a test for this method as I haven't found a unit test for this class. Should we work to add these tests in this pull request?

[gahag]

@carldebilly do you know how can I get a reviewer for this pull request? Thanks.

[davidjohnoliver]

Hi @gahag !

Thanks for your contribution, but I don't think we'll be able to merge this change. This method is used extensively for code generation in the Uno.UI repo and this will be a big breaking change there. Probably this method was misnamed originally, but we're stuck with it now.

If you're still willing to contribute, it would be great to add xml comments documenting how the method actually behaves and the correct usage if you want an actual line break (which is to call AppendLine() with no parameters).

[gahag]

This seems reasonable. I will make another pr adding the documentation. Thanks for the review!