unoplatform / Uno.Gallery

The Uno Platform Gallery application
https://platform.uno/
Other
150 stars 41 forks source link

Update InfoBarSamplePage.xaml with more Infos and color as well added… #1027

Open AryanParashar24 opened 9 months ago

AryanParashar24 commented 9 months ago

… to them depending onto the different conditions as founded in the code

two more Infos are been added in the code with the colors as well been added inot the code specifying the conditions been faced by the customer or developer based on the status of their sitaution

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

morning4coffe-dev commented 9 months ago

@AryanParashar24 Tests seems to be failing on SamplePages\InfoBarSamplePage.xaml(125,11): Error UXAML0001: The 'winui:InfoBar' start tag on line 115 position 9 does not match the end tag of 'winui:InfoBar.Content'. Can you look into it please?

morning4coffe-dev commented 9 months ago

Also @MartinZikmund isn't this one related to https://github.com/unoplatform/Uno.Gallery/pull/308? 🤔

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

AryanParashar24 commented 9 months ago

Hey @morning4coffe-dev @mrlacey plz le me know if it could be improved a bit more by changing anything else

mrlacey commented 9 months ago

Hey @morning4coffe-dev @mrlacey plz le me know if it could be improved a bit more by changing anything else

Not sure if you meant me or @MartinZikmund but I have added some comments.