unoplatform / Uno.Gallery

The Uno Platform Gallery application
https://platform.uno/
Other
152 stars 43 forks source link

fix: Improving Neumorphic ToggleSwitch #1044

Open eriklimakc opened 11 months ago

eriklimakc commented 11 months ago

GitHub Issue (If applicable): closes #1033 and #1034

PR Type

What kind of change does this PR introduce?

github-actions[bot] commented 4 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net

agneszitte commented 4 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net

@kazo0, @eriklimakc, @Xiaoy312 Can you help test the stage site page of this PR please (@eriklimakc can you see the same issues locally for WebAssembly?) On my side I can see weird behavior for wasm: image Try to change the control using the combobox as well... image

agneszitte commented 3 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net

@kazo0, @eriklimakc, @Xiaoy312 Can you help test the stage site page of this PR please (@eriklimakc can you see the same issues locally for WebAssembly?) On my side I can see weird behavior for wasm: image Try to change the control using the combobox as well... image

@morning4coffe-dev can you help qa/test the static web app link + changes locally to see if you can reproduce the issues I am seeing on the static web app link on my side please

morning4coffe-dev commented 3 months ago

@agneszitte @eriklimakc Both locally on WASM and on the static web app, I can see similar behavior. When I try to open the ComboBox for neum. styles, the UI dissapears for me. For both tests using Edge latest stable.

Local

https://github.com/unoplatform/Uno.Gallery/assets/78549750/5c716af1-5145-46e6-9bb2-df6772b985bb

Azure

https://github.com/unoplatform/Uno.Gallery/assets/78549750/2ffab79f-8821-48cf-b2db-6c7e7be01637

agneszitte commented 3 months ago

@agneszitte @eriklimakc Both locally on WASM and on the static web app, I can see similar behavior. When I try to open the ComboBox for neum. styles, the UI dissapears for me. For both tests using Edge latest stable.

Thank you a lot for the test @morning4coffe-dev, is this also happening on latest master please? or it is just related to this PR ?

morning4coffe-dev commented 3 months ago

@agneszitte I tried to check with all the controls in the ComboBox, but I can't reporduce this Issue on latest master. The UI renders normally: image

agneszitte commented 3 months ago

@agneszitte I tried to check with all the controls in the ComboBox, but I can't reporduce this Issue on latest master. The UI renders normally

@eriklimakc I switched this PR as Draft until it is figured out what is happening with the current changes here based on the latest feedback from @morning4coffe-dev that it does not happen on latest master.

github-actions[bot] commented 3 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net

eriklimakc commented 3 months ago

@morning4coffe-dev @agneszitte I rebased from master and I couldn't reproduce it anymore. Could be that some of the changes made in master fixed it?

Can you please retest it?

morning4coffe-dev commented 3 months ago

@eriklimakc @agneszitte Jup, I can't no longer reproduce it either on this branch: image

agneszitte commented 3 months ago

@eriklimakc @agneszitte Jup, I can't no longer reproduce it either on this branch

@eriklimakc and @morning4coffe-dev I am not able to reproduce the issue either now when testing the static web app link associated with the PR.