search

unoplatform / Uno.Gallery

The Uno Platform Gallery application
https://platform.uno/
Other
152 stars 43 forks source link

[Shadow Builder][Safari] Clicking the IconToggleButtons randomly scrolls the page back to the top #985

Closed NVLudwig closed 4 months ago

NVLudwig commented 1 year ago

Current behavior

https://github.com/unoplatform/Uno.Gallery/assets/29584087/ea56791c-ce73-40c4-ac01-d9e025437fcb

Clicking the ToggleButtons will at times trigger a scroll-to-top and it seems to happen randomly, clicking the same button twice will not always give you the same result.

Expected behavior

No scrolling at all

How to reproduce it (as minimally and precisely as possible)

Launch latest safari on mac and navigate to shadowcontainer/IconToggleButton

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

Visual Studio:

Relevant plugins:

Anything else we need to know?

May be related to an issue @eriklimakc is investigating about this behaviour in Chrome in one of his branches

eriklimakc commented 1 year ago

I have the same behavior in one of my branches for Chefs, but not only on Safari, but also in Chrome, and on Android as well.

image-android-issue-toggle-button

ajpinedam commented 1 year ago

@eriklimakc, can I have access to that branch?

Issues seem similar, but starting from the fact that it looks like a ListView/ItemsControl in your sample, I want to say they are different.

I will check it out too.

eriklimakc commented 1 year ago

Also happens (tested Chrome) on this PR https://github.com/unoplatform/Uno.Themes/pull/997.

You can see in the static wasm link here: https://salmon-rock-0cfebe70f-997.eastus2.azurestaticapps.net/

Go to Helpers > ControlExtensions > Click the Leading or Trailing Icon in the TextBox example.

jeromelaban commented 10 months ago

I'm not able to reproduce with latest builds of Safari, @ajpinedam could you validate again? Thanks!

ajpinedam commented 9 months ago

I'm not able to reproduce with latest builds of Safari, @ajpinedam could you validate again? Thanks!

It was reported a similar issue in Chefs and other apps, so the issue still seems to be there.

Xiaoy312 commented 9 months ago

i just noticed something perhaps similar, but on-focus-lost:

i am using Chrome (Version 120.0.6099.217 (Official Build) (64-bit)) gallery shadow toggle onfocuslost

ramezgerges commented 9 months ago

Following Xiao's repro steps gave a different repro. Tested on vivaldi, brave and firefox.

This will only work when a page is first loaded. Changing the page makes it repro again. Also, changing the control in the checkbox inside Toolkit\ShadowContainer will also make it repro (any control will do, not necessarily ToggleButton).

Edit: Oh, a similar repro seems to be unoplatform/Uno.Themes#1062

jeromelaban commented 5 months ago

I cannot reproduce this issue anymore in the canary. @sakshi173 can you try again?

NVLudwig commented 5 months ago

@jeromelaban I reproed it just now check out the recording here. https://github.com/unoplatform/Uno.Gallery/assets/29584087/64615120-bd98-45c2-becb-358b11580869

Note that the expanders in the gallery main navigation do the same thing bu on every click: opening a sections scrolls the list all the way back to the top:

https://github.com/unoplatform/Uno.Gallery/assets/29584087/2d940c0f-d026-4a84-b069-8b61ea2c6f55

I get both issues on both Safari and Chrome

jeromelaban commented 5 months ago

@NVLudwig this happens in prod, but not on the canary. Can you validate: https://unogallerycanary.z27.web.core.windows.net

NVLudwig commented 5 months ago

@jeromelaban indeed the canary link does not have this bug.

I noticed 2 sperate issues while looking into the one above:

  1. FAB seems ro have a problem in the canary (Safari and Chrome) that is not present in prod. Should I make a new issue? It's the icon that has no spacing with the label in canary only.

    Screenshot 2024-05-28 at 10 05 32 AM

  2. Only on Canary+Safari the iconToggleButton "flashes" when you click it's neighbour

https://github.com/unoplatform/Uno.Gallery/assets/29584087/1ef6312b-0a7c-49c3-9dd9-6fd7bc153291

Should I make separate issues?

sakshi173 commented 5 months ago

@jeromelaban and @NVLudwig, I checked this issue on the Canary build using multiple browsers (Chrome, MS Edge, Opera), and it is working fine on all of them. However, as Ludwig mentioned, this issue is specific to the Safari browser. Unfortunately, I don't have Safari installed on my laptop, and my attempts to install it have been unsuccessful. As a result, I am unable to test this issue on Safari. Please let me know if this is acceptable for you. Below is the recording for the Canary build.

https://github.com/unoplatform/Uno.Gallery/assets/74563602/1e47b201-62e8-43da-a514-969f6a6d8c9e

jeromelaban commented 4 months ago

@sakshi173 can test on your mac now please?

sakshi173 commented 4 months ago

@Jerome, I retested this defect on Mac book, and I am able to reproduce it. below is the video

https://github.com/unoplatform/Uno.Gallery/assets/74563602/74b50563-caca-4c67-9d22-587274c662a8

jeromelaban commented 4 months ago

@sakshi173 I'm sorry, I do not see what you're reproducing. I don't see any scrolling up? What are you reproducing?

NVLudwig commented 4 months ago

I think the video refers to one of the other 2 issues I found and was asking about higher up in this thread

sakshi173 commented 4 months ago

@jeromelaban I thought now I have to reproduce this issue "Only on Canary+Safari the iconToggleButton "flashes" when you click it's neighbour" as for the main issue "[Shadow Builder][Safari] Clicking the IconToggleButtons randomly scrolls the page back to the top" , I have already updated that I am not able to reproduce it and we can close them.

jeromelaban commented 4 months ago

Thanks. I see, let's not deal with multiple issues in a single issue. Let's split them instead.

jeromelaban commented 4 months ago

This issue is now split to https://github.com/unoplatform/Uno.Themes/issues/1430 and https://github.com/unoplatform/uno.toolkit.ui/issues/1184