unoplatform / Uno.Playground

Source code for the Uno Gallery apps and Uno Playground (made in Wasm)
https://playground.platform.uno/
Other
214 stars 34 forks source link

[Playground][wasm]Button, ProgressBar, Card- Text is not visible in Dark Theme #481

Open sakshi173 opened 1 year ago

sakshi173 commented 1 year ago

Current behavior

Button failed1 Progress failed Card failed1

Expected behavior

Button correct 2 progress correct Card correct1

How to reproduce it (as minimally and precisely as possible)

  1. Visit https://playgroundcanary.z19.web.core.windows.net/#passwordbox.
  2. Go to the Snippets Listview.
  3. Click on 'Button' or 'Card' or 'ProgressBar' snippets option.
  4. Click checkbox for dark theme.
  5. Observe that the displayed text for the selected sample is not visible in dark theme.

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

jeromelaban commented 1 year ago

This issue is caused by samples not specifying theme resources for brushes.

carlh98 commented 1 year ago

For PasswordBox and ProgressBar, the xaml that is used has Foreground harcoded for the styles, removing the values, fixes the issues since it falls back to the style of the control. image

@agneszitte I do not know where playground gets the xaml for the example, can you point me in the right direction?

agneszitte commented 1 year ago

@carlh98 prepare the snippets and share the saved links in the issue please, we will do the update when @jeromelaban and @carldebilly will be back next week

carlh98 commented 1 year ago

Snippets PasswordBox ProgressBar

I was not able to test locally, after updating to the latest VS Preview (17.8.0 Preview 1.0) I'm getting the following error, I tried updating the bootstrap packages but I'm getting the same error

2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : System.Exception: Failed to execute the linker
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error :    at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.RunPackager() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 1023
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error :    at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.Execute() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 266
2>Done building project "Uno.Playground.WASM.csproj" -- FAILED.
MartinZikmund commented 1 year ago

@ebariche it seems this same problem is now happening in multiple places, any chance you could look into what could be causing it?

jeromelaban commented 1 year ago

@carlh98 can you attach a binlog?

agneszitte commented 1 year ago

@carldebilly can you help to update the playground snippets with the API please?

silviuo commented 1 year ago

Following up on @agneszitte's post in unoventive, here are some issues I discovered when comparing snippets under the three Uno Playground variants (Canary, Staging, Prod):

CalendarView - On Prod only, the down arrow icon shows as the up arrow:

current: image

expected: image

InfoBar (muxc) - on Canary and Staging (Prod correct), the "Informational" Severity icon does not display the foreground "i". For all other types of severity ("Success", "Warning", "Error"), the icon displays correctly on all three builds.

current: image

expected: image

jeromelaban commented 1 year ago

@silviuo interesting! Could you open individual issues for what you've found?

silviuo commented 1 year ago

@jeromelaban I created separate issues for the problems I mentioned in the previous comment.

Related to this particular issue, however, besides the already mentioned snippets (Button, Cards, PasswordBox, ProgressBar), I also found the following that don't display some of the text in dark mode:

agneszitte commented 1 year ago

@silviuo can you share the links of the other issues you opened please

silviuo commented 1 year ago

@silviuo can you share the links of the other issues you opened please

@agneszitte

https://github.com/unoplatform/uno/issues/13282

https://github.com/unoplatform/uno/issues/13283

agneszitte commented 1 year ago

Snippets PasswordBox ProgressBar

I was not able to test locally, after updating to the latest VS Preview (17.8.0 Preview 1.0) I'm getting the following error, I tried updating the bootstrap packages but I'm getting the same error

2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : System.Exception: Failed to execute the linker
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error :    at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.RunPackager() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 1023
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error :    at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.Execute() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 266
2>Done building project "Uno.Playground.WASM.csproj" -- FAILED.

Snippets will be updated with the 5.0 release