Open sakshi173 opened 1 year ago
This issue is caused by samples not specifying theme resources for brushes.
For PasswordBox and ProgressBar, the xaml that is used has Foreground harcoded for the styles, removing the values, fixes the issues since it falls back to the style of the control.
@agneszitte I do not know where playground gets the xaml for the example, can you point me in the right direction?
@carlh98 prepare the snippets and share the saved links in the issue please, we will do the update when @jeromelaban and @carldebilly will be back next week
Snippets PasswordBox ProgressBar
I was not able to test locally, after updating to the latest VS Preview (17.8.0 Preview 1.0) I'm getting the following error, I tried updating the bootstrap packages but I'm getting the same error
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : System.Exception: Failed to execute the linker
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.RunPackager() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 1023
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.Execute() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 266
2>Done building project "Uno.Playground.WASM.csproj" -- FAILED.
@ebariche it seems this same problem is now happening in multiple places, any chance you could look into what could be causing it?
@carlh98 can you attach a binlog?
@carldebilly can you help to update the playground snippets with the API please?
Following up on @agneszitte's post in unoventive, here are some issues I discovered when comparing snippets under the three Uno Playground variants (Canary, Staging, Prod):
CalendarView - On Prod only, the down arrow icon shows as the up arrow:
current:
expected:
InfoBar (muxc) - on Canary and Staging (Prod correct), the "Informational" Severity icon does not display the foreground "i". For all other types of severity ("Success", "Warning", "Error"), the icon displays correctly on all three builds.
current:
expected:
@silviuo interesting! Could you open individual issues for what you've found?
@jeromelaban I created separate issues for the problems I mentioned in the previous comment.
Related to this particular issue, however, besides the already mentioned snippets (Button, Cards, PasswordBox, ProgressBar), I also found the following that don't display some of the text in dark mode:
CheckBox, Image, Path, RadioButton, Shape, ToggleButton - because of labels using hardcoded TextBlock Foreground values e.g.
Panels, TextBlock - because of TextBlocks styled with "SampleSectionTextBlockStyle" StaticResource e.g.
TextBox - because of TextBoxes styled with "AndroidTextBoxStyle" StaticResource e.g.
@silviuo can you share the links of the other issues you opened please
@silviuo can you share the links of the other issues you opened please
@agneszitte
Snippets PasswordBox ProgressBar
I was not able to test locally, after updating to the latest VS Preview (17.8.0 Preview 1.0) I'm getting the following error, I tried updating the bootstrap packages but I'm getting the same error
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : System.Exception: Failed to execute the linker 2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.RunPackager() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 1023 2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.Execute() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 266 2>Done building project "Uno.Playground.WASM.csproj" -- FAILED.
Snippets will be updated with the 5.0 release
Current behavior
Expected behavior
How to reproduce it (as minimally and precisely as possible)
Workaround
No response
Works on UWP/WinUI
None
Environment
No response
NuGet package version(s)
No response
Affected platforms
WebAssembly
IDE
No response
IDE version
No response
Relevant plugins
No response
Anything else we need to know?
No response