unoplatform / Uno.Samples

A collection of code samples for the Uno Platform
http://platform.uno/
Other
211 stars 107 forks source link

[ToDo][Win/iOS][Settings Flyout] Opening Settings Flyout Changes App Theme Without Interacting with Light/Dark Theme Controls #778

Open agneszitte opened 1 month ago

agneszitte commented 1 month ago

Current behavior

Opening the settings flyout changes the theme of the app without having to click on the Light/Dark theme chips controls in the flyout.

Windows:

https://github.com/unoplatform/Uno.Samples/assets/16295702/04d5962f-9d4e-48aa-81ed-182e96aee79e

iOS:

https://github.com/unoplatform/Uno.Samples/assets/16295702/ce617fd9-1534-4481-8862-d7ebd87adf2e

Expected behavior

Opening the settings flyout should not change the theme of the app unless the user interacts with the Light/Dark theme chips controls.

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package:

Affected platform(s):

Additional information

Possible related issue: https://github.com/unoplatform/Uno.Samples/issues/780

agneszitte commented 1 month ago

@rajamatt / @kazo0 The current logic will need to be reviewed: https://github.com/unoplatform/Uno.Samples/blob/af2f226fac8f2e133e1f08000d8ef8cdc974d1e5/reference/ToDo/src/ToDo/Views/Dialogs/SettingsFlyout.xaml#L107 https://github.com/unoplatform/Uno.Samples/blob/af2f226fac8f2e133e1f08000d8ef8cdc974d1e5/reference/ToDo/src/ToDo/Views/Dialogs/SettingsFlyout.xaml.cs#L37

For Windows every time you open the Settings Flyout you go through here if I am not mistaken: https://github.com/unoplatform/Uno.Samples/blob/af2f226fac8f2e133e1f08000d8ef8cdc974d1e5/reference/ToDo/src/ToDo/Views/Dialogs/SettingsFlyout.xaml.cs#L35