unoplatform / Uno.Samples

A collection of code samples for the Uno Platform
http://platform.uno/
Other
207 stars 107 forks source link

[ToDo][Settings Flyout] Wrong Value Checked by Default for Current Theme When Opening Settings Flyout #780

Open agneszitte opened 1 month ago

agneszitte commented 1 month ago

Current behavior

When opening the settings flyout, the wrong value is checked by default for the current theme. The displayed theme mode does not reflect the actual current theme of the app.

image image

Expected behavior

The settings flyout should correctly display the current theme mode by having the appropriate current theme option (Light or Dark) checked by default.

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package:

Affected platform(s):

Additional information

Possible related issue: https://github.com/unoplatform/Uno.Samples/issues/778

agneszitte commented 1 month ago

From https://github.com/unoplatform/Uno.Samples/issues/778

@rajamatt / @kazo0 The current logic will need to be reviewed:

https://github.com/unoplatform/Uno.Samples/blob/af2f226fac8f2e133e1f08000d8ef8cdc974d1e5/reference/ToDo/src/ToDo/Views/Dialogs/SettingsFlyout.xaml#L107

https://github.com/unoplatform/Uno.Samples/blob/af2f226fac8f2e133e1f08000d8ef8cdc974d1e5/reference/ToDo/src/ToDo/Views/Dialogs/SettingsFlyout.xaml.cs#L37

Same here