search

unoplatform / Uno.Themes

This library is designed to help you use the Material, Fluent or Cupertino design system with the Uno Platform
https://platform.uno
Apache License 2.0
167 stars 28 forks source link

fix(RatingControl)!: adjust ratingcontrol resource keys #1350

Closed kazo0 closed 3 months ago

kazo0 commented 3 months ago

BREAKING CHANGE: RatingControl Lightweight Styling keys have changed to align the WinUI resource keys

closes #1349

PR Type

What kind of change does this PR introduce?

Current Behavior

Given the following XAML:

<Grid VerticalAlignment="Center">
    <Grid.RowDefinitions>
        <RowDefinition Height="Auto" />
        <RowDefinition Height="Auto" />
    </Grid.RowDefinitions>
    <RatingControl VerticalAlignment="Center"
                    HorizontalAlignment="Center"
                    Value="3">
        <RatingControl.Resources>
            <SolidColorBrush x:Key="RatingControlSelectedForeground"
                                Color="Red" />
            <SolidColorBrush x:Key="RatingControlUnselectedForeground"
                                Color="Orange" />
        </RatingControl.Resources>
    </RatingControl>
    <Border Grid.Row="1">
        <Border.Resources>
            <MaterialTheme xmlns="using:Uno.Material" />
        </Border.Resources>
        <RatingControl VerticalAlignment="Center"
                        HorizontalAlignment="Center"
                        Value="3">
            <RatingControl.Resources>
                <SolidColorBrush x:Key="RatingControlSelectedForeground"
                                    Color="Red" />
                <SolidColorBrush x:Key="RatingControlUnselectedForeground"
                                    Color="Orange" />
            </RatingControl.Resources>
        </RatingControl>
    </Border>
</Grid>

image

New Behavior

image

kazo0 commented 3 months ago

@Mergifyio backport stable/release/4.1

mergify[bot] commented 3 months ago

backport stable/release/4.1

❌ No backport have been created

* Backport to branch `stable/release/4.1` failed GitHub error: ```Branch not found```
kazo0 commented 3 months ago

@Mergifyio backport release/stable/4.1

mergify[bot] commented 3 months ago

backport release/stable/4.1

✅ Backports have been created

* [#1352 fix(RatingControl)!: adjust ratingcontrol resource keys (backport #1350)](https://github.com/unoplatform/Uno.Themes/pull/1352) has been created for branch `release/stable/4.1` but encountered conflicts