unoplatform / Uno.Themes

This library is designed to help you use the Material, Fluent or Cupertino design system with the Uno Platform
https://platform.uno
Apache License 2.0
167 stars 28 forks source link

fix: move Focused visualstate to CommonStates group #1355

Closed kazo0 closed 3 months ago

kazo0 commented 3 months ago

closes https://github.com/unoplatform/uno/issues/14633 closes #1293

PR Type

What kind of change does this PR introduce?

Description

Move Focused visual state into CommonStates VisualStateGroup to avoid conflicts between the FocuseStates and the CommonStates when an element is Focused and then becomes Disabled.

This sort of VisualState organization can be seen in the Fluent styles as well.

Previous Behavior

button-state-broken

New Behavior

button-state-working

kazo0 commented 3 months ago

@mergifyio backport release/stable/4,1

mergify[bot] commented 3 months ago

backport release/stable/4,1

❌ No backport have been created

* Backport to branch `release/stable/4,1` failed GitHub error: ```Branch not found```
github-actions[bot] commented 3 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1355.eastus2.azurestaticapps.net

github-actions[bot] commented 3 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1355.eastus2.azurestaticapps.net

kazo0 commented 3 months ago

@mergifyio backport release/stable/4.1

mergify[bot] commented 3 months ago

backport release/stable/4.1

✅ Backports have been created

* [#1356 fix: move Focused visualstate to CommonStates group (backport #1355)](https://github.com/unoplatform/Uno.Themes/pull/1356) has been created for branch `release/stable/4.1`