unoplatform / Uno.Themes

This library is designed to help you use the Material, Fluent or Cupertino design system with the Uno Platform
https://platform.uno
Apache License 2.0
170 stars 32 forks source link

[Gallery][WASM][UI Components -TextBox] Misalignment of Clear Button with Cursor When Switching Between Textboxes #1458

Open jhanvi03 opened 2 months ago

jhanvi03 commented 2 months ago

Current behavior

When switching from one textbox to another, the cross sign (clear button) for removing text does not align with the cursor

https://github.com/user-attachments/assets/a1b0dd85-718a-42f7-9a53-aa823ae50f81

Expected behavior

The cross sign (clear button) should be consistently aligned with the cursor when switching between textboxes

How to reproduce it (as minimally and precisely as possible)

  1. Open Galley canary WASM
  2. From the side Menu expand UI components
  3. From UI components click on TextBox
  4. Enter text in one textbox
  5. Enter text in another textbox
  6. switch between 2 textbox and observe the clear sign

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

Anything else we need to know?

Could be related to https://github.com/unoplatform/uno/issues/17914 , https://github.com/unoplatform/uno/pull/17633

agneszitte commented 2 months ago

@eriklimakc can you take a look and leave more info please

eriklimakc commented 2 months ago

From a quick test using an newly created Uno app:

That's wasm only. Apparently the control is not changing to the "Focused" VisualState when it is clicked.

This is reproducible on both the "FilledTextBoxStyle" and the "OutlinedTextBoxStyle". But also with PasswordBox, so I don't think this is a bug brought with the Header/Placeholder changes.

cc @agneszitte @kazo0

eriklimakc commented 2 months ago

This issue is also reproducible using <UnoThemesVersion>5.0.13</UnoThemesVersion>. Version prior to the Header+Placeholder changes. Could it be related to https://github.com/unoplatform/uno/issues/17914?

cc @dr1rrb @Xiaoy312 @kazo0

eriklimakc commented 2 months ago

It's reproducible on fluent from blank template: https://github.com/unoplatform/uno/issues/18040

agneszitte commented 2 months ago

@Youssef1313 is https://github.com/unoplatform/uno/pull/18042 will completely fix this issue, please?

Youssef1313 commented 2 months ago

Yes it should, I think.

agneszitte commented 2 months ago

@jhanvi03 can you retest this issue with latest Gallery canary build to verify if it is fixed please

jhanvi03 commented 2 months ago

Tested with latest canary build and I am still able to reproduce.

https://github.com/user-attachments/assets/636d8d66-0b98-4b0e-8697-251466dff0cb

Youssef1313 commented 2 months ago

Latest available Uno.Sdk doesn't include the fix yet. We need https://github.com/unoplatform/uno.templates/pull/941 first

agneszitte commented 2 months ago

@Youssef1313 if you can update @jhanvi03 when it will be ready for QA again for this issue, it will be appreciated please

Youssef1313 commented 2 months ago

It should be ready for testing again

kazo0 commented 2 months ago

FYI @jhanvi03 I think you should be able to test this now, at least once there is a working canary :)

jhanvi03 commented 2 months ago

The issue is resolved on Mac WASM but persists on iOS. On iOS, when moving the cursor from one textbox to another: -The 'Cross' icon does not appear. -Instead of placing the cursor at the end of the text, all the text gets selected. After deselecting, the 'Cross' icon still does not appear.

MAC WASM: Test Pass Version: Package Referenced version Updated version Uno.Core.Extensions.Compatibility 4.0.1 4.1.1 Uno.Core.Extensions.Disposables 4.0.1 4.1.1 Uno.Sdk 5.3.96 5.4.0-dev.236 Package Referenced version Updated version
Uno.Core.Extensions.Compatibility 4.0.1 4.1.1
Uno.Core.Extensions.Disposables 4.0.1 4.1.1
Uno.Sdk 5.3.96 5.4.0-dev.236

https://github.com/user-attachments/assets/09b72e4e-965b-4885-b5bf-ee0226c37efd

iOS: Test Fail Version: 1.6.0(2409061451.1778)

https://github.com/user-attachments/assets/70bb8226-58af-4047-9ce1-145f0751eb3e

agneszitte commented 2 months ago

The issue is resolved on Mac WASM but persists on iOS

@Youssef1313 I will let you take a look as @jhanvi03 is still able to reproduce on iOS please

Youssef1313 commented 2 months ago

@ajpinedam Would you be able to help with the iOS part of this issue?

ajpinedam commented 2 months ago

@ajpinedam Would you be able to help with the iOS part of this issue?

Yes, sure I can look into it. (@Youssef1313 ).

Thanks @agneszitte for assigning the issue to me :)